-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade vitest to 0.34.6 #2193
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems toEqualTypeOf
is bugged with zod: vitest-dev/vitest#4114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a version that fixes the benchmarking issue but doesn't also introduce this MISMATCH
issue... wonder if it's worth just upgrading vitest in store-sync
where we really need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just upgrading store-sync seems fine to me!
could also try bumping zod to see if this was fixed there?
e2e/packages/sync-test/package.json
Outdated
@@ -30,7 +30,7 @@ | |||
"typescript": "5.1.6", | |||
"viem": "1.14.0", | |||
"vite": "^4.2.1", | |||
"vitest": "^0.31.0", | |||
"vitest": "0.31.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentionally not bumping this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, missed that in my ctrl-f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just upgrading store-sync seems fine to me!
could also try bumping zod to see if this was fixed there?
The errors in the previous PR #2190 appear to be caused by the following reasons, though not confirmed:
Regarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.