feat(common): add createContract, createNonceManager utils #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67c2d6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
reviewed
Aug 9, 2023
| const debug = parentDebug.extend("createContract"); | ||
|
|
||
| // copied from viem because it isn't exported | ||
| // TODO: import from viem? |
There was a problem hiding this comment.
should we open a viem issue for this?
There was a problem hiding this comment.
🤷♂️
hopefully they'll have some better hooks for us for nonce handling
holic
commented
Aug 9, 2023
| throw error; | ||
| }, | ||
| }), | ||
| { throwOnTimeout: true } |
There was a problem hiding this comment.
we don't have a timeout configured but queue.add has a Promise<T | void> return type unless you toggle this on
alvrs
reviewed
Aug 9, 2023
| } | ||
|
|
||
| debug("simulating write", functionName, args, options); | ||
| const { request } = await publicClient.simulateContract({ |
There was a problem hiding this comment.
so the request include the estimated gas limit correct?
alvrs
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out of #1214