Fix CI issue by pinning Keras version to match with TF #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamHillier
reviewed
Nov 4, 2021
| @@ -32,6 +32,9 @@ jobs: | |||
| - name: Fix TFDS for older TF versions | |||
| run: pip install tensorflow_datasets==3.2.* | |||
| if: matrix.tf-version == '1.15.5' || matrix.tf-version == '2.0.4' | |||
| - name: Pin Keras for older TF versions | |||
| run: pip install keras==2.6.0 | |||
| if: matrix.tf-version <= '2.6.0' | |||
There was a problem hiding this comment.
Is this only a problem for 2.6 or others too?
There was a problem hiding this comment.
It is a problem with any TF version < 2.7 in combination with Keras 2.7. So by pinning to Keras 2.6 for older TF versions we should be fine.
AdamHillier
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was failing since yesterday because of a mismatching Keras version as suggested on SO. By explicitly installing
keras==2.6.0it is resolved. It was caused by keras 2.7 being released yesterday (https://pypi.org/project/keras/#history) and since we don't pin it this caused issues.