[0.7.x] Polyfill import.meta.url for CJS builds #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
approved these changes
May 10, 2023
|
Just FYI, dedicated build tools like https://github.com/unjs/unbuild provide this feature out-of-the-box. 👍 I highly recommend using it instead of esbuild directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__dirnameis not supported in MJS.import.meta.urlto the rescue.import.meta.urlis not supported in CJS.Sigh.
This PR migrates to using
import.meta.urland polyfiling the CJS build with the more modern approach.Read more about ES Modules and
__dirnamehere: https://blog.logrocket.com/alternatives-dirname-node-js-es-modules/The polyfill was taken from: evanw/esbuild#1633
Fixes #216