[3.x] Remove thousands separator in time records (#876) #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work if your locale is set to something like |
|
@janolivermr I misunderstood what was going on, thanks for the pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overrides the default thousands separator in the PHP
number_formatfunction used to format the time entries. This allows requests that take over 1s/1000ms to be summed up correctly.For a query with a running time of 1.2s, the current time entry in the database will be
1,200.00. When this is passed toparseFloatin the front end it will be parsed as1.With the change, the value will be stored as
1200.00and correctly parsed as1200.