Issue with Incomplete Log Clearance in clear() Method Due to Disabled Foreign Key Constraints #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clear method - Refactored the `clear()` method to rely on database cascading deletes, removing the need to disable foreign key constraints. - Simplified the truncation process to avoid orphaned records and potential database growth.
clear() method to rely on database cascading deletes, removing the need to disable foreign key constraints. - Simplified the truncation process to avoid orphaned records and potential database growth.Respects Foreign Key Constraints: Unlike TRUNCATE, DELETE respects foreign key constraints and does not require disabling foreign key checks.
|
Thanks. We've reverted this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Laravel Telescope Maintainers,
I’ve encountered a significant issue related to log clearance in the Laravel Telescope. The recent commit from pull request #1507 that disables foreign key constraints within the
DatabaseEntriesRepository::class@clear()method has resulted in incomplete log deletion. Specifically, records in the telescope_entries_tag table are not being cleared, leading to unnecessary database growth over time.This oversight can result in substantial database bloat, especially in environments with high logging activity. I believe addressing this would greatly benefit the efficiency and performance of the package.
Thank you for your attention to this matter.
Best regards