Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Show list of headers when present #1355

Merged
merged 1 commit into from
Jun 3, 2023
Merged

[4.x] Show list of headers when present #1355

merged 1 commit into from
Jun 3, 2023

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jun 2, 2023

When an array of headers is present, we now show the array rather than only the first value.

Incoming Application Request

Screen Shot 2023-06-03 at 11 57 03 am

Outgoing HTTP Client Request

Request see "x-foo"

Screen Shot 2023-06-03 at 11 32 43 am

Response see "set-cookie"

Screen Shot 2023-06-03 at 11 53 28 am

Went wit comma separated list instead of an actual array, as it creates consistency between those that already use the comma as a list mechanism and those that do not.

@timacdonald timacdonald changed the title [4.x] Show array of headers when present [4.x] Show list of headers when present Jun 3, 2023
@timacdonald timacdonald marked this pull request as ready for review June 3, 2023 01:58
@taylorotwell taylorotwell merged commit 8067e85 into laravel:4.x Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants