[4.x] Fix key handling for ModelWatcher #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driesvints If you can, could you please create new release. Thanks |
|
@yasirhashmi88 did this work for you? |
|
Nvm. I'll tag a new release tomorrow. |
|
@driesvints Yes it does. Thanks. |
|
@yasirhashmi88 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a breakage snuck in with my previous PR: #1174. Because the payload is decoded as an associative array (as should because we can't guarantee the data order in the payload), when new events happen with this payload we'll need to reference the named key instead.
It's beyond me why new events are recorded but I guess this can happen since every eloquent model event is being watched.
Fixes #1178