Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link instead of copy provision.sh #192

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

deviantintegral
Copy link
Contributor

Using a hard link means that you don't have to manually copy provision.sh when editing. macOS (and BSD?) don't support cp -l so I'm using ln instead.

@svpernova09
Copy link
Contributor

svpernova09 commented Mar 8, 2019

How does this behave on Windows?

@deviantintegral
Copy link
Contributor Author

Are you thinking in the WSL subsystem? I don't have that currently installed, but https://www.reddit.com/r/bashonubuntuonwindows/comments/77ephs/creating_hard_and_symbolic_links_in_mntc/ indicates hard links should work.

@svpernova09
Copy link
Contributor

Not the WSL (Vagrant in the WSL is a nightmare last I tried)

On WIndows when I build the base box I want to be able to fire off a command to copy/link whatever the provision file to homestead.sh in the bento repo like on MacOS/Linux. I just don't know if Windows will handle the hard links as MacOS will.

@deviantintegral
Copy link
Contributor Author

Windows will handle hard links, but powershell only has an alias for cp and not ln. Are you running the bash script, or manually running cp in powershell?

@svpernova09
Copy link
Contributor

Currently i just manually copy the file in a terminal app (CMDR) via cp. If we could add a Powershell version of the link-to-bento.sh I think that would work.

@svpernova09 svpernova09 merged commit 4bd1ab4 into laravel:master Mar 15, 2019
@deviantintegral
Copy link
Contributor Author

Thanks - I don't have Windows set up for development currently, so it was going to be a while until I could get to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants