Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fixes namespace resolution on named arguments #69

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

nunomaduro
Copy link
Member

This pull request fixes namespace resolution on named arguments. Here is an example of the before / after:

return my_function(
-   a1: new User,
+   a1: new \App\Models\User,
-   a2: User::create(),
+   a2: \App\Models\User::create(),
-   a3: User::ADMIN_TYPE
+   a3: \App\Models\User::ADMIN_TYPE
);

@nunomaduro nunomaduro marked this pull request as ready for review July 13, 2023 14:51
@nunomaduro nunomaduro marked this pull request as draft July 13, 2023 14:52
@nunomaduro nunomaduro marked this pull request as ready for review July 13, 2023 15:02
@taylorotwell taylorotwell merged commit c19f8f3 into master Jul 13, 2023
@taylorotwell taylorotwell deleted the fix/named-arguments-class-resolution branch July 13, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants