[1.x] Updates stream protocol name to avoid collision with opis/closure
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes this package use its own stream protocol ID.
Previously, people can reach this edge case where they can end up deserializing an
laravel/serializable-closurebefore deserializing anopis/closure. As an example, having 2 web servers (one using a new version of Laravel / other using a new version Laravel), and both of them publish queue jobs for a queue server (using a new version of Laravel). When this edge case happens, they could occasionally see this error:stream_wrapper_register(): Protocol closure:// is already defined..Fixes #22.