[1.x] Fixes rebound closures serialization #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0164adb to
8804c95
Compare
|
@nunomaduro this is error: All works correct on laravel 8.60.0 but not on 8.61.0 and 8.62.0 |
|
Can you give me an example @yaroslawww on how to reproduce that? Also, can you ensure you are using the version v1.0.2 of this package? What PHP version are you using? |
|
@nunomaduro Sorry, after research I found problem in other private internal package what use "Illuminate\Queue\SerializableClosure" as wrapper for closure called in queue. After change from "Illuminate\Queue\SerializableClosure" => "Laravel\SerializableClosure\Serializers\Native" all tests passed and functionality works. Thank you for great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes serialization closures that got rebounded. There was missing a "from" method.
Fixes #18