Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Fix collection engine mapIds bug #585

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[9.x] Fix collection engine mapIds bug #585

merged 1 commit into from
Feb 15, 2022

Conversation

amir9480
Copy link
Contributor

Fixes #584.

@driesvints
Copy link
Member

Please explain what and how this is fixing and not link to an issue, thanks.

@amir9480
Copy link
Contributor Author

@driesvints This change resets $results array indices so $results[0] always will exist on line 170 and prevents the Undefined array key 0 exception.

@taylorotwell taylorotwell merged commit d50ed2f into laravel:9.x Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection Engine Undefined array key 0 error
3 participants
@amir9480 @driesvints @taylorotwell