Rename CheckScopes and CheckForAnyScope to CheckAbilities and CheckForAnyAbility #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the ChekScopes and CheckForAnyScope middlewares to CheckAbilities and CheckForAnyAbility.
I sent a PR about a week ago porting the ChekScopes and CheckForAnyScope middlewares from Passport, i later realized that the term ability might be a better fit for Sanctum since scopes are referred as abilities both in the Sanctum docs and throughout the code.
Although this might not be necessary, since we're talking about an undocumented feature released 2 days ago, this PR add no breaking changes. The old middlewares are marked as deprecated and use the logic from the newly added ones (which is the same as before).