Ignore updating last_used_at for deciding the DB connection host
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last_used_at timestamp moved to terminating callback
last_used_at timestamp moved to terminating callbacklast_used_at timestamp moved to terminating callback
|
Hmm - I think you have a good point but we need to solve it in a different way. We can't use the |
|
I have updated this PR - does it look OK to you? |
|
Yes. This approach looks much better. |
last_used_at timestamp moved to terminating callbacklast_used_at updating for deciding the DB connection host
last_used_at updating for deciding the DB connection hostlast_used_at for deciding the DB connection host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sanctum updates the access token's
last_used_atproperty every time an API is authenticated using sanctum guard. This db query happens in the initial phase of the request cycle. This causes all the subsequent db queries to go to writer host even in the case of read operations.Solution
Saving the updated
last_used_atoperation is moved to the application terminating event.