Use non-root MySQL password for sail mysql
#45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small yet separate addendum to my other PR: #44
This PR changes the provided password for to the MySQL CLI on the
sail mysql
command fromMYSQL_ROOT_PASSWORD
toMYSQL_PASSWORD
.Context:
This is for custom Docker Compose setups from before Laravel Sail came out. Sail automatically sets the
MYSQL_ROOT_PASSWORD
env variable to.env
's DB_PASSWORD.When working with a Docker Compose configuration that have separate passwords between the MySQL root user and the MySQL working (i.e. non-root) user,
sail mysql
will throw the classic 'Access denied for user X (using password: YES)' MySQL error.One could also argue that the current call to the MySQL CLI is erroneous since it combines MYSQL_USER (not root) and MYSQL_ROOT_PASSWORD.
This PR fixes this by using MYSQL_PASSWORD instead, as mentioned above. Tested with a fresh Laravel installation to make sure it didn't break.