Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries & timeout to healthcheck #143

Merged

Conversation

rabin-io
Copy link
Contributor

This small patch will help with the support of podman, as some options are required unlike with docker-compose.
should not have any side effects, and even can help if for some reason the service is not ready.

ERROR: for redis  Cannot create container for service redis: fill out specgen: healthcheck-retries must be greater than 0
ERROR: Encountered errors while bringing up the project.

+ Update mariadb.stub
+ Update minio.stub
+ Update mysql.stub
+ Update pgsql.stub
@taylorotwell taylorotwell merged commit 1aacb1c into laravel:1.x May 24, 2021
@rabin-io rabin-io deleted the add-retries-timeout-to-healthcheck branch May 24, 2021 18:37
oddvalue pushed a commit to oddvalue/sail that referenced this pull request May 26, 2021
+ Update mariadb.stub
+ Update minio.stub
+ Update mysql.stub
+ Update pgsql.stub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants