[0.5.x] Ensures precog requests do not interfere with non-precog requests #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
|
Woohoo. I can confirm this PR solves #73. Amazing stuff. ❤️ |
|
Thanks for letting me know, @robdekort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #73
The precognition client will always cancel in-flight requests that match a new outgoing request. This is done to ensure that only the latest validation messages are returned and that we don't get out-of-order responses.
For non-Inertia libraries, we also use the client to submit forms. There are rare situations where a validation request can cancel and actual submission request.
This PR ensures that non-precognitive requests are never cancelled by the library - which is the expected behaviour.
This only impacts the non-Inertia flavoured libraries.