Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swoole in-memory timer table size #819

Closed
wants to merge 1 commit into from

Conversation

miguilimzero
Copy link
Contributor

@miguilimzero miguilimzero commented Jan 19, 2024

The current implementation of the timer table starts to throw some insufficient memory errors when there are a lot of workers ~200 and when all those workers are processing requests at the same time (as reported at #648).

The #650 PR introduced the max_timer_table_size undocumented config value so we can control the timer table size manually to avoid this problem.

However, ensuring the $size passed to the table creation will guarantee the desired number of rows (with #818). We can now use the number of workers to define the timer table size and get rid of the undocumented manual parameter.

@miguilimzero miguilimzero changed the title Fix Swoole timer table size Fix Swoole in-memory timer table size Jan 19, 2024
@taylorotwell
Copy link
Member

I don't understand why we wouldn't just document the configuration option instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants