[1.x] Fix passing null to cookie for domain (#478)

* Throw deprecations * Fix null deprecation
laravel · Feb 14, 2022 · 9d5c8bb · 9d5c8bb
1 parent 1b2d5f5
commit 9d5c8bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -28,6 +28,7 @@ jobs:
         with:
           php-version: ${{ matrix.php }}
           extensions: dom, curl, libxml, mbstring, zip, ${{ matrix.driver }}
+          ini-values: error_reporting=E_ALL
           tools: composer:v2
           coverage: none
 

diff --git a/src/Swoole/SwooleClient.php b/src/Swoole/SwooleClient.php
@@ -192,10 +192,10 @@ public function sendResponseHeaders(Response $response, SwooleResponse $swooleRe
                 $cookie->getValue(),
                 $cookie->getExpiresTime(),
                 $cookie->getPath(),
-                $cookie->getDomain(),
+                $cookie->getDomain() ?? '',
                 $cookie->isSecure(),
                 $cookie->isHttpOnly(),
-                $cookie->getSameSite()
+                $cookie->getSameSite(),
             );
         }
     }