-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change controller validate helper method to behave like Laravel (#1247) #1248
Conversation
Tests are failing here. |
Whoops, I forgot that I overwrote my own exception handler. Looks like Lumen's default handler excepts the response to be set on the ValidationException. Fixed. |
Would this break existing applications? |
…s and throwValidationException
Yes, it would cause a breaking change if anyone overwrote the protected extractInputFromRules or throwValidationException methods. I just updated it to use those methods if they are defined. |
This broke my application. I'm not overwriting |
We're reverting this. |
Hmm, that was an unfortunate oversight. Sorry about that. I think this should be released as a breaking change in the next major version though. The current validation is not behaving as expected. |
#1247