Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add missing Schedule:work command #1243

Merged

Conversation

plourded
Copy link
Contributor

@plourded plourded commented Aug 1, 2022

Simply link the command into the service provider to make it available.

We need this commands to run the scheduler into our Kubernetes clusters. Current options of using "php artisan schedule:run" isn't working for us beacause we have a lot of microservices needing cron job and it was creating to much load on our master node.

Thanks

@taylorotwell taylorotwell merged commit be6f8f3 into laravel:8.x Aug 1, 2022
@GrahamCampbell GrahamCampbell changed the title Add missing Schedule:work command [8.x] Add missing Schedule:work command Aug 2, 2022
@plourded
Copy link
Contributor Author

plourded commented Aug 2, 2022

Hello there,

Small question, what are the steps I need to do to bring that feature into a released version of 8.x and then 9.x ?

thanks
Dominic

@plourded plourded deleted the feature/add-missing-schedule-work-command branch August 2, 2022 12:57
@driesvints
Copy link
Member

@plourded releases are done today.

@driesvints
Copy link
Member

@plourded I noticed you sent this in to Lumen v8 which is not maintained anymore. Please send this in to v9

@plourded
Copy link
Contributor Author

plourded commented Aug 2, 2022

thanks @driesvints , I create the PR to merge 8.x into 9.x: #1244

Sorry if i didn't push into the right branch, the documentation still say 8.X is the branch to push:
All bug fixes should be sent to the latest version that supports bug fixes (currently 8.x) (https://laravel.com/docs/9.x/contributions#which-branch)

@driesvints
Copy link
Member

@plourded you're reading the docs for Laravel (the framework). With Lumen only the latest major version receives bug fixes: https://laravel.com/docs/9.x/releases#support-policy

Screenshot 2022-08-02 at 15 10 25

@plourded
Copy link
Contributor Author

plourded commented Aug 2, 2022

@driesvints thanks

taylorotwell pushed a commit that referenced this pull request Aug 2, 2022
* Add missing clear queue command to service provider (#1237)

* Add missing clear queue command to service porovider

* hotfix: change order of uses to respect ci

Co-authored-by: Dominic Plourde <plourded@amotus.ca>

* Add missing Schedule:work command (#1243)

Co-authored-by: Dominic Plourde <plourded@amotus.ca>

Co-authored-by: Dominic Plourde <plourded@amotus.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants