Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix MakesHttpRequests::call() return type #1239

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[9.x] Fix MakesHttpRequests::call() return type #1239

merged 1 commit into from
Jul 8, 2022

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Jul 8, 2022

Static analysis of a method using call() fails with the following error:

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Testing/MakesGraphQLRequests.php (in context of class Tests\Unit\Testing\TestingTraitDummy)
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  100    Method Tests\Unit\Testing\TestingTraitDummy::multipartGraphQL() should return Illuminate\Testing\TestResponse but returns Illuminate\Http\Response.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------

Static analysis of a method using `call()` fails with the following error:

```
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Testing/MakesGraphQLRequests.php (in context of class Tests\Unit\Testing\TestingTraitDummy)
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  100    Method Tests\Unit\Testing\TestingTraitDummy::multipartGraphQL() should return Illuminate\Testing\TestResponse but returns Illuminate\Http\Response.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------
```
@taylorotwell taylorotwell merged commit ed09e0a into laravel:9.x Jul 8, 2022
@GrahamCampbell GrahamCampbell changed the title Fix MakesHttpRequests::call() return type [9.x] Fix MakesHttpRequests::call() return type Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants