Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] fix: Fluent::fill definition #54434

Closed
wants to merge 1 commit into from
Closed

[11.x] fix: Fluent::fill definition #54434

wants to merge 1 commit into from

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Jan 31, 2025

Hello!

This fixes the following error introduced by #54404:

  In Fluent.php line 19:                                                                                                               
    Declaration of Laravel\Nova\Support\Fluent::fill(array $attributes) must   
  be                                                                           
     compatible with Illuminate\Support\Fluent::fill($attributes)

Thanks!

@calebdw calebdw mentioned this pull request Jan 31, 2025
Closed
@calebdw
Copy link
Contributor Author

calebdw commented Jan 31, 2025

Hmm, looks like there's other things besides arrays being passed in

@calebdw calebdw closed this Jan 31, 2025
@calebdw calebdw deleted the fluent_fill branch January 31, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@calebdw