[11.x] Refactor validation rule parsing for improved readability #54417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaedrich
reviewed
Jan 30, 2025
| return array_map( | ||
| [$this, 'prepareRule'], | ||
| $rule, | ||
| array_fill((int) array_key_first($rule), count($rule), $attribute) |
There was a problem hiding this comment.
The (int) cast doesn't make sense. You probably expect the key to be of type int anyway, but if it for some reason is not, casting a potentially non-empty string to int won't be very helpful, would it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
explodeExplicitRuleto support rules as both strings and arrays. In the future, rules can be used as strings with|for validation, eliminating the need forinstanceofchecks for specific classes like theDaterule.