Fixed incomplete return type signature on insertGetId method. Updated Model class and added test.

[skoskie]

Explanation

There can be unexpected consequences when calling methods like $model->insertAndSetId() or $table->insertGetId() are called and the returned value is false, which is not accounted for in the signatures of those methods. This can happen because both functions return the result of Illuminate\Database\Query\Processors\Processor\processInsertGetId() (also needing a PHPDoc update), which in turn returns the result of PDO\lastInsertId(), which correctly indicates it could return a value of false.

Changes

1. I have updated the PHPDoc signatures in places where it seemed appropriate.
2. I have updated the Model\insertAndSetId() method to not set the attribute if the return value is false. There must be a better way to handle this, but I wanted to be consistent with other database functions and not throw an error.
3. I have added a test for the Model class to handle the case in which the attribute is not set. I'm not sure if I put my test in the right place. Improvements are probably needed anyway.

Note

There are many other places where a false return value from lastInsertId() could be problematic. Further review and tests are encouraged.

Beware

1. This is my first ever attempt at contributing so please accept my apologies if I'm not doing it correctly. 🙏
2. The change to the Model class seems like a be a breaking change to me, so based on the guidelines, I'm hoping I selected the right branch. Again, sorry if I'm getting this wrong.

[taylorotwell]

Going to hold off on this for now.

[skoskie]

Great. Could you at least accept the PHPdoc updates so that the IDE gives the correct information? If Laravel doesn't handle the possible cases, then it should at least be clear to end developers that they have to account for it. From the indicated return type, it isn't clear at all, leading to preventable errors.