Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve eloquent attach parameter consistency #54225

Conversation

fabpl
Copy link

@fabpl fabpl commented Jan 17, 2025

Considering the use of "$ids" parameter in the detach() function, it seems logical to do the same for the attach() function.

@taylorotwell taylorotwell merged commit 8961a43 into laravel:master Jan 17, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants