[11.x] Fallback to parent methods on HasUniqueStringIds trait
#54096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikaraujo
reviewed
Jan 15, 2025
| @@ -38,7 +38,7 @@ public function initializeHasUniqueStringIds() | |||
| */ | |||
| public function uniqueIds() | |||
| { | |||
| return [$this->getKeyName()]; | |||
| return $this->usesUniqueIds() ? [$this->getKeyName()] : parent::uniqueIds(); | |||
There was a problem hiding this comment.
@taylorotwell I don't really understand why, but this change specifically breaks PHPStan/Larastan.
It causes static analysis to think that every model ->id property is int.
I don't know why $this->usesUniqueIds() is false when running static analysis, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
HasUniqueStringIdstrait respect$usesUniqueIdsproperty and fallback to parent methods:uniqueIds()method and fallback to parent if not.getKeyType()andgetIncrementing()method for consistency.This is useful when a model is using this trait optionally by setting
$usesUniqueIdsproperty.