[11.x] remove temporary variables #53810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the declared variable is only used once. inlining does not decrease readability. my guess is it was originally written this way *before* we had arrow functions, and could inherit the outer `$this` scope. also minor formatting update to use our new multiline chaining standard
also put each argument on separate line for multiline for better git diffs
a couple more real simple ones
|
failure seems unrelated to changes. PHP setup was halted. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removal of some simple temporary variables.
some of these were most likely originally written this way due to binding of
$thisprior to arrow functions.