Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Pick up existing views and markdowns when creating mails #53308

Conversation

kevinb1989
Copy link
Contributor

@kevinb1989 kevinb1989 commented Oct 26, 2024

I spend a whole afternoon designing an email template named resources/views/customers/welcome.blade.php.

Then I run the command php artisan make:mail --view=customers.welcome.

And my completed template has been replaced with the stub file.

This is not exactly ideal, and it is easy to fix. People might have existing templates to use, or design them first. If blade files are already present, it would be great if they are picked up.

To be consistent, I do the same with markdowns.

@taylorotwell
Copy link
Member

I would just return an error message that the file already exists.

@taylorotwell taylorotwell marked this pull request as draft October 29, 2024 14:42
@kevinb1989 kevinb1989 marked this pull request as ready for review October 30, 2024 03:47
@kevinb1989
Copy link
Contributor Author

@taylorotwell No problem, I have updated according to your comment.

@taylorotwell taylorotwell merged commit 17acf83 into laravel:11.x Oct 30, 2024
31 checks passed
@kevinb1989
Copy link
Contributor Author

@taylorotwell thanks boss! We plan to refactor our emails to mailables using existing blade files. This will make our lives way easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants