Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP84] Bump aws/aws-sdk-php for PHP 8.4 #53021

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Oct 3, 2024

Fix deprecations of aws/aws-sdk-php implicit nullable type.

Copy link

github-actions bot commented Oct 3, 2024

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@Jubeki Jubeki marked this pull request as ready for review October 3, 2024 06:59
@taylorotwell taylorotwell merged commit 105e496 into laravel:php84 Oct 3, 2024
5 of 9 checks passed
@GrahamCampbell
Copy link
Member

Note that the SDK isn't running PHP-cs-fixer and the corrections upstream did not fix their code generation, so there's a good chance this will break when they next re-generate files.

@Jubeki Jubeki deleted the php84-aws-sdk-php branch October 4, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants