Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] fix: Builder::with closure types #52729

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[11.x] fix: Builder::with closure types #52729

merged 1 commit into from
Sep 10, 2024

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Sep 10, 2024

Hello!

#52724 fixed the Collection types, but this fixes the Builder::{with,withOnly} types as well to specify closures with the Relation passed to them.

Thanks!

CC: @staudenmeir

@calebdw calebdw changed the title fix: Builder::with closure types [11.x] fix: Builder::with closure types Sep 10, 2024
@taylorotwell taylorotwell merged commit 2f83567 into laravel:11.x Sep 10, 2024
33 checks passed
@calebdw calebdw deleted the fix_builder_with branch September 10, 2024 13:38
@calebdw
Copy link
Contributor Author

calebdw commented Sep 10, 2024

Thank you sir!

@kayw-geek kayw-geek mentioned this pull request Sep 12, 2024
Closed
@calebdw calebdw mentioned this pull request Sep 17, 2024
Open
This was referenced Oct 15, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebdw @taylorotwell