Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix altering a table that has a column with default 0 on SQLite #51803

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

hafezdivandari
Copy link
Contributor

Fixes #51747

Modifying a column on a table that has another column with default 0 was causing the default expression to be dropped, this PR fixes that.

This happens only when the table has a column with default 0 as ->default(new Expression('0')) and not ->default(0) that compiles as default '0'.

@taylorotwell taylorotwell merged commit 6c0561c into laravel:11.x Jun 14, 2024
30 checks passed
@hafezdivandari hafezdivandari deleted the 11.x-sqlite-default-zero branch June 14, 2024 17:08
@sezohessen
Copy link

Still facing the same issue after merge @hafezdivandari

@hafezdivandari
Copy link
Contributor Author

@sezohessen you may open an issue with more info and steps to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite issue with default 0 columns when migrating db from schema dump since L11 upgrade
3 participants