[11.x] Explicit nullable parameter declarations to fix PHP 8.4 deprecation #50922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Apr 4, 2024
|
Thanks @Jubeki |
duncanmcclean
added a commit
to statamic/cms
that referenced
this pull request
Nov 19, 2024
Due to another PR preventing deprecation warnings: laravel/framework#50922
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resend of #50921 to the 11.x branch
@GrahamCampbell
Should the rule
nullable_type_declarationsbe added to the styleci config? (would this also result in changes in the 10.x branch if committed to 11.x?). I would leave such a change to you if you want because you know how styleci evaluates the config best.Seems similar to the rule I used with Pint / PHP-CS-Fixer
nullable_type_declaration_for_default_null_value, except that the description is a little different.