[11.x] Use a generic message for ValidationException #50556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #35524 without any breaking changes.
Since this message is not something that ever should reach an end user, these should also never be translated. Because we're pulling messages from the error bag of the validator, part of the message was translated, while the other one we computed wasn't. The original intent of #35524 of showing the first error message was good but it's at the same time weird to just show the first error message and not the other potential ones. Since the error messages are user-facing and the exception message developer facing, we've decided to move this exception message back to a generic one. Also to prevent issues like #50534.