Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Implement Key Rotation Functionality in KeyGenerateCommand #50322

Closed
wants to merge 2 commits into from
Closed

[11.x] Implement Key Rotation Functionality in KeyGenerateCommand #50322

wants to merge 2 commits into from

Conversation

SamAsEnd
Copy link
Contributor

@SamAsEnd SamAsEnd commented Mar 1, 2024

This pull request introduces the ability to rotate application keys in the Laravel environment file. The --rotate option has been added to the key:generate command. When this option is used, the current application key is added to a list of previous keys stored in the APP_PREVIOUS_KEYS environment variable, and a new application key is generated.

This feature is inspired because of @taylorotwell Laracon EU 2024 presentation.
We can now pass --rotate on the key:generate command.

@SamAsEnd SamAsEnd changed the title Implement Key Rotation Functionality in KeyGenerateCommand [11.x] Implement Key Rotation Functionality in KeyGenerateCommand Mar 1, 2024
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

SamAsEnd added a commit to SamAsEnd/laravel-key-rotate that referenced this pull request Mar 30, 2024
SamAsEnd added a commit to SamAsEnd/laravel-key-rotate that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants