Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Add missing putFile to Filesystem contract #50193

Closed
wants to merge 1 commit into from

Conversation

rihardsgrislis
Copy link

@rihardsgrislis rihardsgrislis commented Feb 21, 2024

Hey,

Storage::disk('custom')->putFile(
    'custom',
    new File("/tmp/{$filename}"),
    "{$client->id}_{$client->name}/{$filename}"
);

Since disk method returns \Illuminate\Contracts\Filesystem\Filesystem Intellisense is yelling at me for using putFile because the contract is missing it. Copied the method header from:

public function putFile($path, $file = null, $options = [])

Are there any implications for adding this method to the contract?

@taylorotwell
Copy link
Member

Can't add to a contract on a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants