fix hidden crsf token input not accepting autocomplete #48987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses the following issue when validating HTML code: "An `input` element with a `type` attribute whose value is `hidden` must not have an `autocomplete` attribute whose value is `on` or `off`."
AndrewMast
reviewed
Nov 13, 2023
| @@ -323,7 +323,7 @@ function cookie($name = null, $value = null, $minutes = 0, $path = null, $domain | |||
| */ | |||
| function csrf_field() | |||
| { | |||
| return new HtmlString('<input type="hidden" name="_token" value="'.csrf_token().'" autocomplete="off">'); | |||
| return new HtmlString('<input type="text" style="display:none" name="_token" value="'.csrf_token().'">'); | |||
There was a problem hiding this comment.
I would argue that simply removing the autocomplete attribute would be best. Hidden input types are an established type and changing this could potentially have reaching effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue when validating HTML code: "An
inputelement with atypeattribute whose value ishiddenmust not have anautocompleteattribute whose value isonoroff."