Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Change newPendingRequest() method from protected to public #48949

Closed
wants to merge 1 commit into from
Closed

[10.x] Change newPendingRequest() method from protected to public #48949

wants to merge 1 commit into from

Conversation

pascalbaljet
Copy link
Contributor

This PR makes the newPendingRequest() method on the HTTP Client Factory publicly accessible. This way, you can instantiate a new PendingRequest class with the Global Middleware applied, as there's no other way to get the Global Middleware from outside of the factory.

The PendingRequest class is used by Saloon's Laravel Plugin, but it currently lacks support for Global Middleware because it can't access the $globalMiddleware array. See also saloonphp/laravel-http-sender#15.

If this change is not desired, I could also submit an alternative PR that simply adds a getGlobalMiddleware() method to the HTTP Client Factory.

@pascalbaljet pascalbaljet marked this pull request as ready for review November 8, 2023 15:03
@pascalbaljet
Copy link
Contributor Author

Closed as this is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant