-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Verify hash config #48814
[10.x] Verify hash config #48814
Conversation
01fc91f
to
17d0606
Compare
17d0606
to
f5c22cd
Compare
if ( | ||
$options['memory_cost'] > $this->memory || | ||
$options['time_cost'] > $this->time || | ||
$options['threads'] > $this->threads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should compare the other way, allowing more threads (maybe until a limit) because less threads means more computation time
If someone is getting the error the cause is solution: remove this line from |
@ismaail You should not. I will slow down your tests. Best way to fix it is to follow the changes made in laravel/laravel#6259 class UserFactory extends Factory
{
+ protected static ?string $password;
// ...
public function definition(): array
{
return [
// ...
- 'password' => '$2y$12$Z/vhVO3e.UXKaG11EWgxc.EL7uej3Pi1M0Pq0orF5cbFGtyVh0V3C', // password
+ 'password' => static::$password ??= Hash::make('password'), |
Thank you @bastien-phi.
This issue cropped up for me in 10.30 specifically in the event someone else runs into this. |
I didnt feel comfortable removing it. Checked the updated laravel hash config and seen the value was updated to 12. I changed the phpunit.xml value: |
No description provided.