Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] hash improvements #48791

Closed
wants to merge 1 commit into from
Closed

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Oct 23, 2023

This will break:

Aside from that I don't see concrete examples that a new value is passing through the setter where you expect it not to be using the current algorithm. No doubt there will be edge cases out there.

@timacdonald timacdonald changed the title [10.x] Verify hash matches configuration [10.x] hash improvements Oct 23, 2023
@valorin
Copy link
Contributor

valorin commented Oct 23, 2023

@timacdonald check out the PR by @bastien-phi at bastien-phi#1

Rejecting hashes that don't exactly match in the Hash cast has the potential to break things. We don't think it's safe to assume the hash will always exactly match the configuration, but should be more flexible. If you're in the middle of a password upgrade, you may have the situation where some hashes are still on an older configuration because the user hasn't logged in with their password yet.

I think it'd be ok for a major version (i.e. 11.x) - the dev would have to update code to factor it in and not needless pass around the hash, plus generate for testing rounds, but probably not for 10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants