[10.x] Call renderForAssertions
in all Mailable assertions
#48254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Laravel docs for Mail -- https://laravel.com/docs/10.x/mail the following code snippet is shown:
The
$mailable->assertFrom('jeffrey@example.com');
example here will fail the test because the mailable'srender()
hasn't been called yet. I noticed in the PR #47728 - therenderForAssertions
function was called forassertHasSubject
but I could not see why this isn't being called for the other Mailable assertion functions, such asassertFrom
taken from the docs.So, in summary I've added the
renderForAssertions
to the following functions:Which will no longer mean that the user needs to call a specific
$mailable->assertHasSubject()
or$mailable->assertSeeInHtml()
before being able to call the above methods.