[10.x] Support providing subquery as value to where
builder method
#48116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is impossible to provide a subquery as the $value in a
where
builder method. You can only achieve awhere
with a subquery by providing the subquery as the first parameter. When doing that, you must also wrap the column name inDB::raw()
otherwise the Builder will think the column name is just a raw value. When you use an operator, you also have to reverse that operator, which makes the code less readable/logical in my opinion.This PR fixes that, so you can just provide the column name first, and then provide the subquery as the “value” parameter. That makes the code cleaner and more readable.
I targeted the 10.x branch because I think changing the parameter signature of a protected method is not a breaking change, but I'm not sure. If that is regarded as a breaking change, I will create a new PR against the master branch.