[10.x] Fix BusFake::assertChained() for a single job #47832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug when using the
Bus::assertChained()method with an array containing only a single job.It always returns an assertion error:
The expected chain can not be empty.Providing two or more jobs works fine.
This PR resolves this issue by removing a check if the
$expectedChainis empty, which is the case, if only one job is provided as the first one gets removed from the$expectedChainon line 323.Another solution would be to move the check upwards before the
array_slice(). But because there was no failing test when removing the check, I decided to remove it entirely.If you prefer to keep the check please let me know. I will adjust the PR and add the missing test for that.