Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix return types #47561

Merged
merged 2 commits into from
Jun 25, 2023
Merged

[10.x] Fix return types #47561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d428fb
Update Signals.php
PerryvanderMeer Jun 24, 2023
2ab7a91
Update RedisStore.php
PerryvanderMeer Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Cache/RedisStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public function flush()
/**
* Remove all expired tag set entries.
*
* @return bool
* @return void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right fix. The result of each flushState should be &&ed together, and the result returned.

*/
public function flushStaleTags()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Console/Signals.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ protected function initializeSignal($signal)
/**
* Unregister the current signal handlers.
*
* @return array<int, array<int, callable(int $signal): void>>
* @return void
*/
public function unregister()
{
Expand Down