Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Allow % symbol in component attribute names #47509

Closed
wants to merge 2 commits into from

Conversation

JayBizzle
Copy link
Contributor

@JayBizzle JayBizzle commented Jun 20, 2023

I was recently dealing with a component where we wanted to use the Alpine intersect plugin, but soon realised you couldn't do something like this...

<x-component class="font-bold" x-intersect.margin.-50%.0px="visibleSection = 'profile'" />

It seems the Blade component compiler doesn't allow % symbols in attribute names.

Im not sure if there is a reason for this, or if it is an oversight, but I had a go at fixing it, so here it is.

@JayBizzle JayBizzle changed the title [11.x] Allow % symbol in attribute names [11.x] Allow % symbol in component attribute names Jun 20, 2023
@JayBizzle JayBizzle marked this pull request as ready for review June 20, 2023 14:19
@taylorotwell
Copy link
Member

Send to 10.x please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants