[10.x] Bug in reset() with string path

[daftspunk]

Report

Related class: Illuminate\Database\Migrations\Migrator

The reset() method interface hints at a string for the $paths argument, which is accurate to marry up with the rollback() interface.

/**
 * Rolls all of the currently applied migrations back.
 *
 * @param  array|string  $paths
 * @param  bool  $pretend
 * @return array
 */
public function reset($paths = [], $pretend = false);

However passing a string to this method fails:

// Eg:
$migrator->reset(base_path('database/migrations'));

Actual

Exception is thrown.

In Migrator.php line 346:

  Illuminate\Database\Migrations\Migrator::resetMigrations(): Argument #2 ($paths) must be of type array, string given, called in ~\vendor\laravel\framework\src\Illuminate\Database\Migrations\Migrator.php on line 331

Expect

Happy path.

Proposal

Use an internal type cast/check at the first instance the variable is used.

Have a great day.