Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] use AWS SES v2 Client for ses mailer #45930

Closed
wants to merge 3 commits into from
Closed

[10.x] use AWS SES v2 Client for ses mailer #45930

wants to merge 3 commits into from

Conversation

jacobmllr95
Copy link
Contributor

Using the AWS SES v2 Client automatically increases the 10 MB outbound and 30 MB inbound message size limit to 40 MB, as further explained in this blogpost: https://aws.amazon.com/de/about-aws/whats-new/2022/04/amazon-ses-v2-supports-email-size-40mb-inbound-outbound-emails-default/

This is quite a huge deal, especially when dealing with email attachments.

@ziming
Copy link
Contributor

ziming commented Feb 3, 2023

currently I had to have multiple mailers and switch whenever the attachment size go above ses v1 limits. this will be a great improvement.

is there something breaking that makes u target v10 instead of v9?

@jacobmllr95
Copy link
Contributor Author

@ziming I wasn't sure if switching a service API version is a breaking change or not, so I targeted v10.
If targeting v9 is fine, there should not be any breaking changes.

@taylorotwell
Copy link
Member

taylorotwell commented Feb 3, 2023

Personally I would make this an entirely new transport alongside the current v1 transport... like ses-v2 or something.

I lean that way because people can pass options to the SesClient, and those options may be different across versions.

@jacobmllr95
Copy link
Contributor Author

@taylorotwell We can also go this route an target Laravel 9, if you would prefer that.
The thing about that is that it's quite a bit code duplication and would also required additional documentation.

@taylorotwell
Copy link
Member

The class is fairly small - I don't consider it a burdensome amount of code duplication.

@jacobmllr95
Copy link
Contributor Author

Don't get me wrong, it's not that much duplicated code.
But then we have two sns transports and the user has to decide which one to use.

When AWS releases v3, do we add a third sns transport?
When do we drop support for v1?
And so one...

But in the end it's up to you :)

@deleugpn
Copy link
Contributor

deleugpn commented Feb 5, 2023

I think it's not about giving users too many options. In fact, it could very well be that only v2 becomes documented and v1 fades out. But with 2 classes there's no chance existing code would break because of this change in Laravel.

@taylorotwell
Copy link
Member

Feel free to open a PR as a separate transport as discussed.

@jacobmllr95 jacobmllr95 deleted the feat-use-aws-ses-v2-client branch February 9, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants