-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] use AWS SES v2 Client for ses
mailer
#45930
Conversation
currently I had to have multiple mailers and switch whenever the attachment size go above ses v1 limits. this will be a great improvement. is there something breaking that makes u target v10 instead of v9? |
@ziming I wasn't sure if switching a service API version is a breaking change or not, so I targeted v10. |
Personally I would make this an entirely new transport alongside the current v1 transport... like I lean that way because people can pass options to the |
@taylorotwell We can also go this route an target Laravel 9, if you would prefer that. |
The class is fairly small - I don't consider it a burdensome amount of code duplication. |
Don't get me wrong, it's not that much duplicated code. When AWS releases v3, do we add a third But in the end it's up to you :) |
I think it's not about giving users too many options. In fact, it could very well be that only v2 becomes documented and v1 fades out. But with 2 classes there's no chance existing code would break because of this change in Laravel. |
Feel free to open a PR as a separate transport as discussed. |
Using the AWS SES v2 Client automatically increases the 10 MB outbound and 30 MB inbound message size limit to 40 MB, as further explained in this blogpost: https://aws.amazon.com/de/about-aws/whats-new/2022/04/amazon-ses-v2-supports-email-size-40mb-inbound-outbound-emails-default/
This is quite a huge deal, especially when dealing with email attachments.