[9.x] Ignore whitespaces/newlines when finding relations in model:show
command
#45608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
show:model
relies on reading methods' source code to finding relations. It's done by finding if the pattern\$this->{$possibleRelationMethod}(
appears in the method.In most situation, it would work:
But if there are whitespaces/newlines after
$this
, the command would failed to detect:1
This PR fixes this issue by trimming each line of the relation method's source code, so the pattern
\$this->{$possibleRelationMethod}(
can be correctly detected.Footnotes
Example code from Laravel Documentation ↩