[9.x] Fix relative links for regular files #44519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel's
storage:link --relative
command breaks when configuring paths to regular files.How to reproduce
Add
symfony/filesystem
to support relative links:Add link to regular file in
config/filesystems.php
:Run storage link command with relative option:
Results in...
... because the relative path now has a trailing slash:
../README.md/
.This PR mitigates a bug in Symfony's filesystem component which dates back all the way to 2012, introduced in Laravel 8.x.
I wouldn't expect this bug to be fixed in Symfony itself anytime soon given its history. The fix on Laravel's framework level is simple enough without breaking any existing behaviour (I don't think this particular case ever worked in the first place).
This could be backported to 8.x easily if desired; adhering to the support policy.